Use font awesome names for icons #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Een saai maar secuur klusje, prima geschikt om de tijd te doden tijdens een lange vlucht |
| | 'add' | ||
| | 'add-user' | ||
| | 'advance' | ||
| | 'badge-check' // achievement |
There was a problem hiding this comment.
Ik heb de oorspronkelijke namen nog even laten staan als comment. Dat is wel handig als we ObsIdentify ook doen. Kan daarna weg.
jonathan-waarneming-nl
approved these changes
Sep 18, 2023
src/lib/Icons.ts
Outdated
| 'chevron-circle-right': { light: faChevronCircleRightLight, solid: faChevronCircleRightSolid }, | ||
| camera: { light: faCameraLight, solid: faCameraSolid }, | ||
| 'play-circle': { light: faPlayCircleLight, solid: faPlayCircleSolid }, | ||
| 'chevron-circle-left': { light: faChevronCircleLeftLight, solid: faChevronCircleLeftSolid }, | ||
| 'qr-code': { light: faQrcodeLight, solid: faQrcodeSolid }, |
There was a problem hiding this comment.
Dit zou eigenlijk 'qrcode' moeten zijn
Ja, lijkt me een goed idee. |
| @@ -146,7 +146,8 @@ import { faUserSlash as faUserSlashSolid } from '@fortawesome/pro-solid-svg-icon | |||
| import { faUsersSlash as faUsersSlashSolid } from '@fortawesome/pro-solid-svg-icons/faUsersSlash' | |||
| import { faVenus as faVenusSolid } from '@fortawesome/pro-solid-svg-icons/faVenus' | |||
|
|
|||
| type IconName = | |||
| type IconName = Extract< | |||
| FontawesomeIconName, | |||
There was a problem hiding this comment.
Ik heb de namen nog een extra constraint gegeven, waardoor we zeker zijn dat we dezelfde namen als fontawesome gebruiken. (hierdoor kwam ik er ook achter dat qr-code verkeerd geschreven was)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.