-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use font awesome names for icons #9
Use font awesome names for icons #9
Conversation
Een saai maar secuur klusje, prima geschikt om de tijd te doden tijdens een lange vlucht |
| 'add' | ||
| 'add-user' | ||
| 'advance' | ||
| 'badge-check' // achievement |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ik heb de oorspronkelijke namen nog even laten staan als comment. Dat is wel handig als we ObsIdentify ook doen. Kan daarna weg.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Zal ik deze ook aanpassen en mergen?
src/lib/Icons.ts
Outdated
'chevron-circle-right': { light: faChevronCircleRightLight, solid: faChevronCircleRightSolid }, | ||
camera: { light: faCameraLight, solid: faCameraSolid }, | ||
'play-circle': { light: faPlayCircleLight, solid: faPlayCircleSolid }, | ||
'chevron-circle-left': { light: faChevronCircleLeftLight, solid: faChevronCircleLeftSolid }, | ||
'qr-code': { light: faQrcodeLight, solid: faQrcodeSolid }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dit zou eigenlijk 'qrcode'
moeten zijn
Ja, lijkt me een goed idee. |
@@ -146,7 +146,8 @@ import { faUserSlash as faUserSlashSolid } from '@fortawesome/pro-solid-svg-icon | |||
import { faUsersSlash as faUsersSlashSolid } from '@fortawesome/pro-solid-svg-icons/faUsersSlash' | |||
import { faVenus as faVenusSolid } from '@fortawesome/pro-solid-svg-icons/faVenus' | |||
|
|||
type IconName = | |||
type IconName = Extract< | |||
FontawesomeIconName, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ik heb de namen nog een extra constraint gegeven, waardoor we zeker zijn dat we dezelfde namen als fontawesome gebruiken. (hierdoor kwam ik er ook achter dat qr-code
verkeerd geschreven was)
No description provided.