Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature to detect device's remove/insert events. #30

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add feature to detect device's remove/insert events. #30

wants to merge 2 commits into from

Conversation

walker-WSH
Copy link

@walker-WSH walker-WSH commented Apr 28, 2021

Description

Add feature to detect device's remove/insert events. When device is inserted, win-dshow can restore camera when received event.
However, to be enable to detect remove/insert, we must success to initialize dshow firstly.
Besides, it seems insert/remove events won't be sent for audio filter.

Motivation and Context

Help win-dshow to restore camera when device is inserted.

How Has This Been Tested?

Tested on Window10 with Legitech C920

Types of changes

New feature (non-breaking change which adds functionality)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@walker-WSH
Copy link
Author

walker-WSH commented Apr 28, 2021

After merging this PR, we can improve win-dshow to restore camera automatically:

1619590349

@walker-WSH
Copy link
Author

@jp9000 Request your review

@dodgepong
Copy link
Member

This will not be reviewed until some time after v27 is released.

@walker-WSH
Copy link
Author

This will not be reviewed until some time after v27 is released.

Got it!

@walker-WSH
Copy link
Author

Hmm~
will this PR be merged ?

@jp9000
Copy link
Member

jp9000 commented Jan 18, 2022

sorry about that, I'll try to get around to it sooner than later, it's just easy for things to slide (especially when they're on repositories other than the main repository)

@walker-WSH
Copy link
Author

@PatTheMav @RytoEX
can you help review this PR ? thanks~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants