Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libobs: Deprecate obs_get_transition_by_[name|uuid] #11206

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

libobs: Deprecate obs_get_transition_by_[name|uuid] #11206

wants to merge 1 commit into from
+8 −2

Commits on Oct 5, 2024

  1. libobs: Deprecate obs_get_transition_by_[name|uuid] 

    obs_get_transition_by_name is very problematic because transitions are
always private and their names aren't unique. This means that the method
iterates over all private sources and then takes the first that both is
a transition and matches the name we're looking for. However, this could
be from anywhere - it could be a frontend transition, but also a source
transition, quick transition, or even one from third-party plugins. This
is always never what is intended.

As such, this method (which should never have been added in the first
place) needs to go. In its place, obs_frontend_get_transitions returns a
list of all frontend transitions (which is usually what people are
looking for), and alternatively obs_get_source_by_uuid also provides
access to private sources.

While we're at it, obs_get_transition_by_uuid is basically a wrapper for
obs_get_source_by_uuid and not really necessary. UUID's are unique and
a source doesn't suddenly change its type, so if you have a transition's
UUID you can be pretty sure that when you do obs_get_source_by_uuid, it
will still be a transition.
    @gxalpha
    gxalpha committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    99234f6 View commit details
    Browse the repository at this point in the history