Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Missing Encoder Check on Startup/Profile load #11340

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

derrod
Copy link
Member

@derrod derrod commented Oct 3, 2024

Description

Adds additional checks to the nvenc test binary, and uses it to show a descriptive error message on startup if NVENC was selected and is now missing.

Example:
Example Warning Screenshot

Motivation and Context

Want to make it more obvious to users why NVENC has gone missing, especially those with Kepler GPUs.

How Has This Been Tested?

Tested with modifications to the nvenc test binary to produce various error codes.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

UI/window-basic-main-profiles.cpp Outdated Show resolved Hide resolved
UI/window-basic-main-profiles.cpp Outdated Show resolved Hide resolved
UI/window-basic-main-profiles.cpp Outdated Show resolved Hide resolved
UI/window-basic-main-profiles.cpp Outdated Show resolved Hide resolved
@derrod derrod force-pushed the startup-nvenc-check branch 3 times, most recently from 67244b2 to 75b14b1 Compare October 5, 2024 00:33
@WizardCM WizardCM added the New Feature New feature or plugin label Oct 5, 2024
@derrod derrod changed the title WIP: Encoder Missing Warning Add Missing Encoder Check on Startup/Profile load Oct 5, 2024
@derrod derrod marked this pull request as ready for review October 5, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Feature New feature or plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants