cmake: Use fixed SOVERSION everywhere #11345
Merged
+6
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkartaltepe
commented
Oct 5, 2024
tytan652
approved these changes
Oct 5, 2024
There was a problem hiding this comment.
I forgot to froze the version in the symlink command to create 0 from 30 and not from major.
I purposefully avoided to use a variable and used a fixed value, since set_target_properties_obs will need some rework to support version arguments. (Not worth to bike-shed over that)
PatTheMav
approved these changes
Oct 5, 2024
We missed a spot when freezing the SOVERSION to 30 after we flipped to 31 causing builds to break.
kkartaltepe
force-pushed
the
soversion-30-fix
branch
from
23737c9
to
599b80a
Compare
Conan-Kudo
reviewed
Oct 5, 2024
Lain-B
approved these changes
Oct 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We missed a spot when freezing the SOVERSION to 30 after we flipped to 31 causing builds to break.
Also use a variable which maybe makes it slightly easier to avoid in the future.
Motivation and Context
Believe it or not, sometimes we do want to build on linux.
How Has This Been Tested?
Replicated CI issue and Works on my machine (tm).
Types of changes
Checklist: