Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: check for cycle imports #350

Merged
merged 1 commit into from
Aug 30, 2024
Merged

feat: check for cycle imports #350

merged 1 commit into from
Aug 30, 2024

Conversation

yjose
Copy link
Member

@yjose yjose commented Aug 30, 2024

What does this do?

Cycle dependencies may lead to unpredictable results especially if you
have many of them.

Why did you do this?

Add an ESLint rule to enforce checking for cyclic dependencies as an error.

Who/what does this impact?

NA

How did you test this?

Locally

Copy link

netlify bot commented Aug 30, 2024

Deploy Preview for obytes-starter canceled.

Name Link
🔨 Latest commit 89593ce
🔍 Latest deploy log https://app.netlify.com/sites/obytes-starter/deploys/66d207b83b4df400088d23ab

Copy link
Contributor

💯 Test Coverage

Lines Statements Branches Functions
Coverage: 40%
38.85% (183/471) 34.09% (75/220) 25.27% (46/182)

😎 Tests Results

Tests Skipped Failures Errors Time
40 0 💤 0 ❌ 0 🔥 26.106s ⏱️
👀 Tests Details • (40%)
File% Stmts% Branch% Funcs% LinesUncovered Line #s
All files38.8534.0925.2740.04 
report-only-changed-files is enabled. No files were changed in this commit :)

@yjose yjose merged commit 42cd327 into master Aug 30, 2024
10 checks passed
@yjose yjose deleted the require-cycle-check branch September 10, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant