Fix dynamic_state to use new Effect syntax #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmcgilchrist
force-pushed
the
dynamic_state
branch
2 times, most recently
from
5acf2d9
to
d611e99
Compare
dhil
approved these changes
Nov 27, 2023
| let x = perform S1.Get in | ||
| perform (S2.Put (string_of_int x ^ "xx")); | ||
| perform S2.Get | ||
|
|
There was a problem hiding this comment.
Maybe we should include the runner:
let main3 () =
run3 (module S1) 0 (fun () -> run3 (module S2) "" test3)There was a problem hiding this comment.
It may be worth noting that layering the integer state inside the string state works as well, i.e.
let main3' () =
run3 (module S2) "" (fun () -> run3 (module S1) 0 test3)
multishot/dynamic_state.ml
Outdated
|
|
||
| This example also includes an unneccessary extra 'Choice' effect to | ||
| demonstrate the combination of other effects with state in the same | ||
| handler. This uses the experimental Obj.clone_continuation function to clone |
There was a problem hiding this comment.
Suggested change
| handler. This uses the experimental Obj.clone_continuation function to clone | |
| handler. This uses the external `Multicont.Deep.clone_continuation` function to clone |
| a := String.length !b; | ||
| b := string_of_int !a; | ||
| print_endline !b) | ||
| else print_endline !b |
There was a problem hiding this comment.
I suppose for consistency it would be good to include the runner here as well, e.g. main4 () = run4 test4.
tmcgilchrist
force-pushed
the
dynamic_state
branch
from
d611e99
to
ffa2111
Compare
tmcgilchrist
force-pushed
the
dynamic_state
branch
from
ffa2111
to
5175692
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix dynamic_state to use new Effect syntax, could possibly be simplified further. The type checking inside the effect handlers is a bit fragile, if you reorder the matches in
runorrun2they no longer type check.version 1 fails with
Exception: Stdlib.Effect.Unhandled(LocalState(R).New(1))version 2 passed with
int = 5version 3 I couldn't work out how to run it properly.
version 4 passed producing
3 3