OCaml 4.13 compatibility #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psafont
force-pushed
the
ocaml4.13
branch
2 times, most recently
from
5e7fab7 to
2fb7dc1
Compare
|
PR looks good - many thanks! 😃 For the workflow, I was just merging #339 last night that includes a CI workflow update for 4.14 to |
|
Will change the workflow, then, it'll be less trouble |
Co-authored-by: Pau Ruiz Safont <[email protected]>
|
Should be good to go now |
jmid
approved these changes
May 2, 2023
jmid
added a commit
that referenced
this pull request
May 3, 2023
jmid
added a commit
that referenced
this pull request
May 15, 2023
Avoid using Seq.equal which was added in 4.14. Initially fixed in #340 and then broken in #342. Co-authored-by: Pau Ruiz Safont <[email protected]> Co-authored-by: Edwin Török <[email protected]>
jmid
added a commit
that referenced
this pull request
May 15, 2023
Avoid using Seq.equal which was added in 4.14. Initially fixed in #340 and then broken in #342. Co-authored-by: Pau Ruiz Safont <[email protected]> Co-authored-by: Edwin Török <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the change mentioned in #329 (comment)
I've added a workflow to make sure the compatibility doesn't get broken, let me know if this is inconvenient for you.
I've opened the PR rather than waiting for edwin to come back because with the current situation, the patch is needed in order to make CI pass for xapi-project/xen-api#4985 so I'd rather get the compatibility merged sooner rather than later