-
Notifications
You must be signed in to change notification settings - Fork 6
dev meeting 20200917
Present at the meeting:
- Jérémie Dimino (@jeremiedimino)
- Carl Eastlund (@ceastlund)
- Sonja Heinze (@pitag-ha)
- Nathan Rebours (@NathanReb)
- Nathan adds support for writing a bucklescript driver in ppxlib
- Nathan releases 4.11 ppxlib
- Carl adds 4.12 support to OMP
- Sonja finishes ppxlib's local Astlib
Nathan's been working on preparing the 4.11 ast bump release. He released the few features we added recently before doing so. The 4.11 bump makes a change in string constants in the AST so this might impact a lot of ppx-es. Because a lot of janestreet ppx-es aren't comaptible with the latest ppxlib it's been hard to build the rev-deps and send patches.
Carl hasn't worked on ppxlib this week.
Sonja kept working on our local Astlib, it's making progress but she's run into technical issues. Jérémie will help with this.
Discussing the ocamlformat situation with Jérémie we decided that it's in fact okay to release OMP with 4.12 ast types and migrations ahead of the actual compiler release. If the types change by then, we can upgrade opam-repo so those versions of OMP won't get picked with a 4.12+ compiler. Carl will work on that release!
We also talked about how we are going to move forward with the plan. Keeping the Astlib
work on a separate branch is going to be a bit of challenge maintenance-wise so we will instead merge it to master once it's ready and get rid of the OMP dependency to use our local Astlib for migrations. That will prevent us from having to maintain both OMP and Astlib.
It shouldn't be a problem for people that were using OMP2 since it will provide the same API anyway so they can easily move to Astlib.
Another thing to keep in mind once we are there is that the support for new compiler versions in Astlib should be released before bumping ppxlib's internal AST so that people can use new compiler versions without necessarily having to upgrade all their ppx-es straight away.
It won't be a problem anymore once Astlib is merged into the compiler but in the meantime we have to be careful about this.