Perf: Emit trace events from load_build_directory_exn
#10891
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to get more granular information on traces about the rule loading process. It adds events for all the steps performed in
load_build_directory_exn
.Regular profiles look contain more information:
I must be doing something wrong though, because when one looks at the results using Firefox Profile (which doesn't collapse events), the durations of similar events happening in separate build folders always take the same time. Maybe it is related to memoization?
This is visible in the animation below, here is the trace file used for it:
dune_trace_load_rules.json