-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "coqdoc_header" and "coqdoc_footer" fields. #11131
base: main
Are you sure you want to change the base?
Conversation
2091f8b
to
969a669
Compare
969a669
to
afd123d
Compare
While we are here, shall we add a |
We should add a test where the header file comes as the target of another rule. We need to check that the dependencies are being correctly handled. Variable expansion is also another one that should be checked, but I'm not certain what the best way to do that is yet. |
afd123d
to
883ea56
Compare
@Alizter I added a test that should exercise both at once.
I'm not sure what you have in mind here, actually. Can't we just use the |
883ea56
to
7b75def
Compare
we already set |
and+ coq_dump = Dune_rules.Coq.Coq_rules.coq_env ~dir >>| Dune_rules.Coq.Coq_flags.dump | ||
and+ coq_dump = | ||
Dune_rules.Coq.Coq_rules.coq_env ~dir | ||
>>| Dune_rules.Coq.Coq_flags.dump ~dir:(Path.build dir) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I played around a bit with dropping the directory here, and I couldn't find a good way to do it. I'm not too worried about this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I wasn't sure what to do there.
Does it make sense to pass these flags when in latex mode? I think this might error out coqdoc. Should be simple to add a test for that. |
Signed-off-by: Rodolphe Lepigre <[email protected]>
7b75def
to
dc1181b
Compare
The option is actually ignored (I had tested this), but I guess there is no point in introducing potential dependencies for the latex documentation. I pushed a fix. |
This is an attempt at fixing #11017.
Although I have a working test-case, I have not done much testing so far. I'd appreciate early feedback anyway, if you can find the time to have a quick look @Alizter, @ejgallego.
What remains to be done: