Rename sources into pins #11186
Merged
Rename sources into pins #11186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 6, 2024
rgrinberg
approved these changes
Dec 7, 2024
gridbugs
approved these changes
Dec 9, 2024
It is more consistent if the stanzas in dune-project and dune-workspace are called pins and the names reflect that. Signed-off-by: Marek Kubica <[email protected]>
Leonidas-from-XIV
force-pushed
the
pins-named-pins
branch
from
456fcba to
e9336b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is more consistent if the stanzas in
dune-projectanddune-workspaceare called pins and the names reflect that.sourcesis potentially a better name butpinis for better or worse the established term in OPAM so calling them pins internally is probably a good thing. No functionality changes in this PR.