[3.17] (no_dynlink): do not build .cmxs (#11176)
#11189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Do not build .cmxs when library is (no_dynlink) Signed-off-by: Nicolás Ojeda Bär <[email protected]> * Add test Signed-off-by: Nicolás Ojeda Bär <[email protected]> * Changes Signed-off-by: Nicolás Ojeda Bär <[email protected]> * Improve test Signed-off-by: Nicolás Ojeda Bär <[email protected]> * Add test Signed-off-by: Nicolás Ojeda Bär <[email protected]> --------- Signed-off-by: Nicolás Ojeda Bär <[email protected]> (cherry picked from commit 41212a5)
|
The failure is on macOS CI is fixed via #11179. |
The macos patch utility doesn't like it when a patch contains no hunks, so this change adds a hunk to the patch used in the ignored-dune-lock test. Signed-off-by: Stephen Sherratt <[email protected]>
maiste
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #11176 to 3.17. cc @maiste