Better error message for old versions of Git #11197
Open
+26
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sudha247
force-pushed
the
no-write-fetch-head
branch
from
3125099 to
5b9b8ab
Compare
maiste
reviewed
Dec 12, 2024
Leonidas-from-XIV
requested changes
Dec 12, 2024
There was a problem hiding this comment.
Nice. I like that it doesn't add additional calls to detect that flag!
Added some comments to improve and probably needs to either be rebased on #11198 when it is merged or just exclude the change to setup.default.ml.
| Stdune.Io.read_file path, exit_code) | ||
| ~prefix:"dune" | ||
| ~suffix:"run_with_exit_code" | ||
| ~dir:(Path.of_string (Filename.get_temp_dir_name ())) |
There was a problem hiding this comment.
Maybe put
let temp_dir = Path.of_string @@ Filename.get_temp_dir_name () inin the definition of the function since that stays constant throughout the whole run of the function, no need to compute this on every run.
There was a problem hiding this comment.
As far as I can tell, it'd be computed the same number of times if it were in the function definition - I checked it with some debug prints, but maybe I'm missing something.
Sudha247
force-pushed
the
no-write-fetch-head
branch
from
c3edae8 to
d4c5928
Compare
Sudha247
force-pushed
the
no-write-fetch-head
branch
from
d4c5928 to
d9c750f
Compare
Old versions of git don't support the flag. This patch detects this particular failure and prints an error message hinting that. Signed-off-by: Sudha Parimala <[email protected]>
Signed-off-by: Sudha Parimala <[email protected]>
maiste
force-pushed
the
no-write-fetch-head
branch
from
d9c750f to
346ac96
Compare
maiste
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old versions of git don't support the
--no-write-fetch-headflag. This patch detects this particular failure and prints an error message hinting that. Fixes #10976. Prints the following error message --