Fix promotion of directory targets without files in them #11203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored by Alpha DIALLO <[email protected]> Signed-off-by: Ambre Austen Suhamy <[email protected]>
|
Thanks, that looks like a very userful improvement especially wrt to the cache issue. Adding some other reviewers to this PR as I will be off for the rest of 2024. |
moyodiallo
approved these changes
Dec 16, 2024
|
Hi folks, sorry for my lack of response on this issue, which is indeed IMHO very important. I'll be still away for a few weeks due to personal stuff, but I hope to be back soon. I think it'd be great to get the opinion of @rleshchinskiy which unless I am mistaken is the person who last touched that code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #10931.
On that PR, my colleague @moyodiallo made some comments with significant requested changes. He finally proposed something that seemed to work here. Since then however, he left the company. I am here making a PR with his code.
This may fix #10609, cc @ejgallego.