Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reset the uid counter when restoring the typer's state #1779

Merged
merged 4 commits into from
Jun 11, 2024
Merged

Reset the uid counter when restoring the typer's state #1779

merged 4 commits into from
Jun 11, 2024

Commits on Jun 11, 2024

  1. Add test showing issue with unstable uids

    @voodoos
    voodoos committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    1ed529e View commit details
    Browse the repository at this point in the history

  2. Reset uid counter when restoring the typer's state 

    This ensures UIDs are stable between edits.
Since some table use uids as keys, we have to clean them properly.
This is done using the Stamped_hashtable datastructure introduced in 147f0c3
    @voodoos
    voodoos committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    bc794bf View commit details
    Browse the repository at this point in the history

  3. Add a change entry for ocaml#1779

    @voodoos
    voodoos committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    1cf79be View commit details
    Browse the repository at this point in the history

  4. Update tests and prevent them from running 

    when Dune is < 3.16
when ocaml-index is not installed
    @voodoos
    voodoos committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    42bda3d View commit details
    Browse the repository at this point in the history