Run tests on revdeps #338
Open
Run tests on revdeps #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There does not seem to be a way to run reverse-dependencies tests currently. We would like to do that for ppx_deriving CI (see ocaml-ppx/ppx_deriving#227). In this commit, I propose to run tests on reverse-dependencies when `TESTS=true` (the default) and `REVDEPS` is `true` or lists some reverse dependencies to test (no by default).
thierry-martinez
added a commit
to thierry-martinez/ppx_deriving
that referenced
this pull request
May 24, 2020
It is the default. Here is a pull-request to allow reverse-dependencies to be tested. ocaml/ocaml-ci-scripts#338
|
Shouldn't this be merged too? @kit-ty-kate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There does not seem to be a way to run reverse-dependencies tests currently. We would like to do that for ppx_deriving CI (see ocaml-ppx/ppx_deriving#227).
In this pull-request, I propose to run tests on reverse-dependencies when
TESTS=true(the default) andREVDEPSistrueor lists some reverse dependencies to test (no by default).