Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a link to the opam file on the package overview page #764

Merged
merged 4 commits into from
Jan 6, 2023

Conversation

tmattio
Copy link
Collaborator

@tmattio tmattio commented Jan 6, 2023

Closes #755

Copy link
Collaborator

@sabine sabine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might need better contrast, icon size / stroke width of icon is different to the icon of the repository link.

LGTM otherwise.

@tmattio
Copy link
Collaborator Author

tmattio commented Jan 6, 2023

Thanks, I updated the stroke width. The contrast is the same as the other links, so I think we can keep it like this?

@sabine
Copy link
Collaborator

sabine commented Jan 6, 2023

Screenshot 2023-01-06 at 12-46-05 solo5 0 7 5 · OCaml Package

Icon size is inconsistent with the icon above which is used in a similar role.

Other than that, I think it's okay.

@cuihtlauac
Copy link
Collaborator

BTW, do we need the arrow-top-right-on-square? I don't get the point

@tmattio
Copy link
Collaborator Author

tmattio commented Jan 6, 2023

Ok, the links in the overview are getting messy and inconsistent, so I did some work to make it more consistent.
Here's the result:
image
And when the documentation fails:
image

@cuihtlauac
Copy link
Collaborator

Much nicer!

@cuihtlauac
Copy link
Collaborator

Me being cheeky: Shouldn't the source tarball link receive the same treatment?

@tmattio
Copy link
Collaborator Author

tmattio commented Jan 6, 2023

Shouldn't the source tarball link receive the same treatment?

The sources are a bit different: we need to display the hash, which is long, so we need a way to scroll it horizontally if we want it on the side panel. It's also common to have multiple sources, so a separate section seems sensible.

@sabine
Copy link
Collaborator

sabine commented Jan 6, 2023

It is an great improvement (specifically the icons being aligned so neatly, and using better icons goes such a long way).

My only peeve is the removal of the emphasized nature of the documentation link and the repository link. It would be better if these highly important items would still be more emphasized so even new users can find them quickly. I find the documentation link much harder to click now because it is so much smaller.

I suggest returning the documentation to a CTA-button and making the repository link highlighted in orange by default (as previously, except that now it nicely sits together with the other, less important links).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edit link to opam file from package page
3 participants