Preview ocamlformat 0.27.0 preview1 #1227
Conversation
The aim of this preview is to gather feedback. Changelog can be found here: https://github.com/ocaml-ppx/ocamlformat/blob/main/CHANGES.md
There was a problem hiding this comment.
Great to have a release of ocamlformat with support for 5.2!
Most of the changes are related to the parse-docstrings being true by default. Making two commits (one setting parse-docstrings=false and version=0.27.0 and the second one removing parse-docstrings=false) would make it easier to see what part of the code change.
I left some very minor comments, it looks good to me.
| {- module | ||
| system | ||
| documentation | ||
| including |
There was a problem hiding this comment.
This is strange doc formatting!
There was a problem hiding this comment.
Fixed: ocaml-ppx/ocamlformat#2607
| `Simple_reference of | ||
| string |
There was a problem hiding this comment.
This line break seems unnecessary!
There was a problem hiding this comment.
Fixed: ocaml-ppx/ocamlformat#2606
| match kind with Doc _ -> false | _ -> true | ||
| match kind with | ||
| | Doc _ -> false | ||
| | _ -> true |
There was a problem hiding this comment.
Are match always on multiple lines now?
There was a problem hiding this comment.
This is due to the comment being on its own line:
let _ =
(* foo *)
match kind with
| Doc _ -> false
| _ -> true
let _ = (* foo *) match kind with Doc _ -> false | _ -> trueI think it makes sense, if this match is important enough to require a comment, it should also be made more readable and editable.
There was a problem hiding this comment.
Makes a lot of sense. The comment was so big that I did not notice it.
Thanks for al the fixes!
| analysis, and hence these types are capable of representing values that will | ||
| be rejected by further stages, for example, invalid references or headings that | ||
| are out of range. *) | ||
| {{:https://ocaml.org/releases/4.12/htmlman/ocamldoc.html} The manual} for a |
There was a problem hiding this comment.
The space in {{!ref} content} and {{:link} content} seems a bit weird to me!
There was a problem hiding this comment.
Also fixed: ocaml-ppx/ocamlformat#2608
| match kind with Doc _ -> false | _ -> true | ||
| match kind with | ||
| | Doc _ -> false | ||
| | _ -> true |
There was a problem hiding this comment.
This is due to the comment being on its own line:
let _ =
(* foo *)
match kind with
| Doc _ -> false
| _ -> true
let _ = (* foo *) match kind with Doc _ -> false | _ -> trueI think it makes sense, if this match is important enough to require a comment, it should also be made more readable and editable.
| `Simple_reference of | ||
| string |
There was a problem hiding this comment.
Fixed: ocaml-ppx/ocamlformat#2606
| {- module | ||
| system | ||
| documentation | ||
| including |
There was a problem hiding this comment.
Fixed: ocaml-ppx/ocamlformat#2607
The aim of this preview is to gather feedback.
Changelog can be found here: https://github.com/ocaml-ppx/ocamlformat/blob/main/CHANGES.md