[new release] pgx_lwt_mirage, pgx_value_core, pgx_async, pgx_unix, pgx_lwt_unix, pgx_lwt and pgx (2.0) #18675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…x_lwt_unix, pgx_lwt and pgx (2.0) CHANGES: ### Breaking changes * The Pgx module is now wrapped, which means `Pgx_aux`, `Types`, `Access`, etc. aren't added to the global scope. The main result of this is that `Pgx_value` now needs to be accessed as `Pgx.Value`. (arenadotio/pgx#103) * `Pgx_async.connect` and `with_conn` now have an additional optional `?ssl` argument (see below). ### Added * Pgx_async now supports TLS connections using Conduit_async. This is enabled by default and can be controlled with the new `?ssl` argument to `connect` and `with_conn`. (arenadotio/pgx#108) ### Fixed * Improved message for authentication errors. Previously these raised `Pgx_eof`, and now they raise `PostgreSQL_Error("Failed to authenticate with postgres server", additional details ...)`. (arenadotio/pgx#105) ### Changed * Support new Mirage-conduit timeout argument (arenadotio/pgx#95).
|
Thanks! Could you return the fixes to the opam files upstream? |
I added most of these fixes to arenadotio/pgx#113 For our license, I think the fix incorrectly assumed we're using LGPLv2.1 but we're stuck on LGPLv2.0 (since we have to match PG'OCaml: https://github.com/darioteixeira/pgocaml/blob/master/LICENSE.txt). For the pinned/dev thing, I think that section is generated by dune so I'm not sure how to fix it. Do we need a newer version of dune or something? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pgx using Lwt on Mirage for IO
CHANGES:
Breaking changes
Pgx_aux,Types,Access, etc. aren't added to the global scope.The main result of this is that
Pgx_valuenow needs to be accessed asPgx.Value.(Set Pgx module to wrapped arenadotio/pgx#103)
Pgx_async.connectandwith_connnow have an additional optional?sslargument (see below).Added
new
?sslargument toconnectandwith_conn.(Add TLS support for Pgx_async arenadotio/pgx#108)
Fixed
Pgx_eof, and now they raisePostgreSQL_Error("Failed to authenticate with postgres server", additional details ...).(improve message for authentication errors arenadotio/pgx#105)
Changed