Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HOMEBREW_NO_AUTO_UPDATE=1 to homebrew packages #23586

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

samoht
Copy link
Member

@samoht samoht commented Mar 28, 2023

See Homebrew/brew#14663 (comment) for the rational.

/cc @kit-ty-kate

@avsm
Copy link
Member

avsm commented Mar 28, 2023

Shouldn't this just be added by the opam depext integration? There doesn't seem to be a case where you wouldn't want this variable set on macOS when using Homebrew with opam.

@samoht samoht changed the title Add HOMEBREW_NO_INSTALL_FROM_API=1 to homebrew packages Add HOMEBREW_NO_AUTO_UPDATE=1 to homebrew packages Mar 28, 2023
@mseri
Copy link
Member

mseri commented Mar 29, 2023

This needs to go there, I think you are right, but it would not solve the issue for most users since the current opam and previous depext would not pick up the fix.

I think this was also the discussion with had when HOMEBREW_NO_INSTALL_FROM_API = "1" was introduced.

@samoht
Copy link
Member Author

samoht commented Mar 30, 2023

I'm merging this to unlock the CI on macOS, but I've also opened ocaml-opam/opam-depext#151 to track the proper fix.

@samoht samoht merged commit c56da6f into ocaml:master Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants