[new release] passage (0.1.4) #26430
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CHANGES: - Add bash completions on install
Khady
reviewed
Aug 28, 2024
| ] | ||
| ] | ||
| dev-repo: "git+https://github.com/ahrefs/passage.git" | ||
| install: [make "install_bash_completions"] |
There was a problem hiding this comment.
I think that this breaks installation of the binary. Please do not merge as is
long term suggestion for the CI, might be interesting to have a way to compare what is installed by a new release to what was installed by a previous one |
|
|
closing as this isn't working as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passage - used to store and manage access to shared secrets
CHANGES: