Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new release] colombe, sendmail and sendmail-lwt (0.9.0) #26581

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

dinosaure
Copy link
Contributor

SMTP protocol in OCaml

CHANGES:

@raphael-proust
Copy link
Collaborator

Windows CI error message:

   #=== ERROR while installing mingw-w64-shims.0.2.0 =============================#
  Cannot copy D:\opamroot\default\.opam-switch\build\mingw-w64-shims.0.2.0\shim.exe to D:\opamroot\default\bin\x86_64-w64-mingw32-gcc.exe (D:\opam\bin\opam.exe: "open" failed on D:\opamroot\default\bin\x86_64-w64-mingw32-gcc.exe: Permission denied).

I don't know if that's a setup issue with the ci script or the install process…

@mseri
Copy link
Member

mseri commented Sep 18, 2024

For packages with a public repository one may argue that an email is not even necessary, for anything one can open an issue in the repo after all. I would also not be strict on the number of emails present.

As per windows 🤷‍♂️ I don't really know

@dinosaure
Copy link
Contributor Author

So I rebased everything to satisfy everyone about this release. It should be good now 👍.

@mseri
Copy link
Member

mseri commented Sep 19, 2024

Thanks

@mseri mseri merged commit 25dd411 into ocaml:master Sep 19, 2024
2 of 3 checks passed
@mseri
Copy link
Member

mseri commented Sep 19, 2024

@shonfeder is it possible to relax the linter to avoid failing if at least one email is present (or even if a public repository is listed imo)?

@dinosaure dinosaure deleted the release-colombe-v0.9.0 branch September 19, 2024 07:59
@shonfeder
Copy link
Collaborator

shonfeder commented Sep 19, 2024

@shonfeder is it possible to relax the linter to avoid failing if at least one email is present (or even if a public repository is listed imo)?

Let's take the discussion to ocaml/infrastructure#152 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants