Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package cudajit.0.5.0 #26651

Merged
merged 3 commits into from
Oct 4, 2024
Merged

Conversation

lukstafi
Copy link
Contributor

cudajit.0.5.0

Bindings to the cuda and nvrtc libraries with a unified interface
Bindings to manually selected parts of lcuda and lnvrtc, with a few types and conversion functions to facilitate use.



🐫 Pull-request generated by opam-publish v2.3.1

@lukstafi
Copy link
Contributor Author

Passing CI test target: https://github.com/lukstafi/ocaml-cudajit/actions/runs/11112452563/job/30874592644
I also updated lower bounds.

"Bindings to the `cuda` and `nvrtc` libraries with a unified interface"
description:
"Bindings to manually selected parts of `lcuda` and `lnvrtc`, with a few types and conversion functions to facilitate use."
maintainer: ["Lukasz Stafiniak"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a contact email here? (This is part of a tighter policy we are trying to ease in.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done (forgot about this).

@shonfeder
Copy link
Collaborator

See #26542 (comment) to explain the CI failures.

As an aside, and for the future, ye need a way to handle CI for this sort of package in the future, as it is not practical to add a x-ci-accept-failure for every platform. I'm opening a separate issue to track this.

@lukstafi
Copy link
Contributor Author

lukstafi commented Oct 3, 2024

See #26542 (comment) to explain the CI failures.

As an aside, and for the future, we need a way to handle CI for this sort of package in the future, as it is not practical to add a x-ci-accept-failure for every platform. I'm opening a separate issue to track this.

Note the failures are already attributable to conf-cuda, which would be the primary beneficiary of ocurrent/opam-repo-ci#371 .
So a separate feature request would be to have a more elaborate blame assignment. (I realize it's less trivial than just not blaming a package if its dependency failed to build.)

@lukstafi
Copy link
Contributor Author

lukstafi commented Oct 3, 2024

@shonfeder
Copy link
Collaborator

Nice! Thanks for the additional CI results and for the fix here. Your suggestion is also excellent, and I've referred that upstream.

@shonfeder shonfeder merged commit e1ec530 into ocaml:master Oct 4, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants