[package update] Strenghten dependencies constraints in Ortac packages #26697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmid
reviewed
Oct 9, 2024
There was a problem hiding this comment.
Overall, with the Ortac packages we are trying to make things work together within versions, while avoiding issues arising from cross-version combinations, like ortac-core.0.4 and ortac-qcheck-stm.0.2.
The changes LGTM for doing so!
I think there is also an occurrence in packages/ortac-core/ortac-core.0.3.0/opam that needs = version but then everything should be version-aligned AFAICS!
"ortac-runtime" {with-test}
Future versions are expected to break these packages.
Next release is expected to include breaking changes
n-osborne
force-pushed
the
ortac-dep-constraints
branch
from
c74b516 to
4969138
Compare
|
Good catch, I missed this one! |
|
The I've just filed #26702 to add missing upper bounds to address it. |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates some dependencies constraints for some Ortac packages.
When an Ortac package depends on another Ortac package, make the constraints ask for the exact same version.
The reason why is that version 0.4.0 brings some breaking changes (see #26691) and we can't guarantee that it will be an isolate case.
Constraints on the Gospel package are also added, as the next release is expected to bring breaking changes.