Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package ppx_minidebug.2.0.3 #27198

Merged
merged 3 commits into from
Jan 13, 2025

Conversation

lukstafi
Copy link
Contributor

@lukstafi lukstafi commented Jan 2, 2025

ppx_minidebug.2.0.3

Debug logs for selected functions and let-bindings
Formatted logs of let-bound values, function arguments and results; if and match branches taken. Optionally, as collapsible HTML trees with highlights.



🐫 Pull-request generated by opam-publish v2.5.0

@shonfeder
Copy link
Contributor

We are seeing a revdep failure:

[ERROR] The compilation of arrayjit.0.4.1 failed at "dune build -p arrayjit -j 39 @install".

#=== ERROR while compiling arrayjit.0.4.1 =====================================#
# context              2.4.0~alpha1~dev | linux/x86_64 | ocaml-base-compiler.5.2.1 | file:///home/opam/opam-repository
# path                 ~/.opam/5.2/.opam-switch/build/arrayjit.0.4.1
# command              ~/.opam/opam-init/hooks/sandbox.sh build dune build -p arrayjit -j 39 @install
# exit-code            1
# env-file             ~/.opam/log/arrayjit-7-533a22.env
# output-file          ~/.opam/log/arrayjit-7-533a22.out
### output ###
# (cd _build/default && /home/opam/.opam/5.2/bin/ocamlc.opt -w -40 -g -bin-annot -bin-annot-occurrences -I arrayjit/lib/.arrayjit.objs/byte -I /home/opam/.opam/5.2/lib/backoff -I /home/opam/.opam/5.2/lib/base -I /home/opam/.opam/5.2/lib/base/base_internalhash_types -I /home/opam/.opam/5.2/lib/base/md5 -I /home/opam/.opam/5.2/lib/base/shadow_stdlib -I /home/opam/.opam/5.2/lib/base_bigstring -I /home/opam/.opam/5.2/lib/base_quickcheck -I /home/opam/.opam/5.2/lib/base_quickcheck/ppx_quickcheck/runtime -I /home/opam/.opam/5.2/lib/bigarray-compat -I /home/opam/.opam/5.2/lib/bin_prot -I /home/opam/.opam/5.2/lib/bin_prot/shape -I /home/opam/.opam/5.2/lib/camlzip -I /home/opam/.opam/5.2/lib/core -I /home/opam/.opam/5.2/lib/core/base_for_tests -I /home/opam/.opam/5.2/lib/core/command -I /home/opam/.opam/5.2/lib/core/filename_base -I /home/opam/.opam/5.2/lib/core/heap_block -I /home/opam/.opam/5.2/lib/core/univ_map -I /home/opam/.opam/5.2/lib/core/validate -I /home/opam/.opam/5.2/lib/ctypes -I /home/opam/.opam/5.2/lib/ctypes-foreign -I /home/opam/.opam/5.2/lib/fieldslib -I /home/opam/.opam/5.2/lib/gel -I /home/opam/.opam/5.2/lib/int_repr -I /home/opam/.opam/5.2/lib/integers -I /home/opam/.opam/5.2/lib/jane-street-headers -I /home/opam/.opam/5.2/lib/mtime -I /home/opam/.opam/5.2/lib/mtime/clock -I /home/opam/.opam/5.2/lib/multicore-magic -I /home/opam/.opam/5.2/lib/ocaml/str -I /home/opam/.opam/5.2/lib/ocaml/threads -I /home/opam/.opam/5.2/lib/ocaml/unix -I /home/opam/.opam/5.2/lib/ocaml_intrinsics_kernel -I /home/opam/.opam/5.2/lib/ocannl_npy -I /home/opam/.opam/5.2/lib/parsexp -I /home/opam/.opam/5.2/lib/ppx_assert/runtime-lib -I /home/opam/.opam/5.2/lib/ppx_bench/runtime-lib -I /home/opam/.opam/5.2/lib/ppx_compare/runtime-lib -I /home/opam/.opam/5.2/lib/ppx_diff/diffable -I /home/opam/.opam/5.2/lib/ppx_diff/diffable_cinaps -I /home/opam/.opam/5.2/lib/ppx_enumerate/runtime-lib -I /home/opam/.opam/5.2/lib/ppx_expect/config -I /home/opam/.opam/5.2/lib/ppx_expect/config_types -I /home/opam/.opam/5.2/lib/ppx_expect/make_corrected_file -I /home/opam/.opam/5.2/lib/ppx_expect/runtime -I /home/opam/.opam/5.2/lib/ppx_hash/runtime-lib -I /home/opam/.opam/5.2/lib/ppx_here/runtime-lib -I /home/opam/.opam/5.2/lib/ppx_inline_test/config -I /home/opam/.opam/5.2/lib/ppx_inline_test/runtime-lib -I /home/opam/.opam/5.2/lib/ppx_log/syntax -I /home/opam/.opam/5.2/lib/ppx_log/types -I /home/opam/.opam/5.2/lib/ppx_minidebug/runtime -I /home/opam/.opam/5.2/lib/ppx_module_timer/runtime -I /home/opam/.opam/5.2/lib/ppx_sexp_conv/runtime-lib -I /home/opam/.opam/5.2/lib/ppx_stable_witness/runtime -I /home/opam/.opam/5.2/lib/ppx_stable_witness/stable_witness -I /home/opam/.opam/5.2/lib/ppx_string/runtime -I /home/opam/.opam/5.2/lib/ppxlib/print_diff -I /home/opam/.opam/5.2/lib/printbox -I /home/opam/.opam/5.2/lib/printbox-html -I /home/opam/.opam/5.2/lib/printbox-md -I /home/opam/.opam/5.2/lib/printbox-text -I /home/opam/.opam/5.2/lib/ptime -I /home/opam/.opam/5.2/lib/ptime/clock -I /home/opam/.opam/5.2/lib/re -I /home/opam/.opam/5.2/lib/saturn_lockfree -I /home/opam/.opam/5.2/lib/seq -I /home/opam/.opam/5.2/lib/sexplib -I /home/opam/.opam/5.2/lib/sexplib0 -I /home/opam/.opam/5.2/lib/splittable_random -I /home/opam/.opam/5.2/lib/stdio -I /home/opam/.opam/5.2/lib/stdlib-shims -I /home/opam/.opam/5.2/lib/time_now -I /home/opam/.opam/5.2/lib/typerep -I /home/opam/.opam/5.2/lib/tyxml -I /home/opam/.opam/5.2/lib/tyxml/functor -I /home/opam/.opam/5.2/lib/uucp -I /home/opam/.opam/5.2/lib/uutf -I /home/opam/.opam/5.2/lib/variantslib -I /home/opam/.opam/5.2/lib/zip -no-alias-deps -open Arrayjit -o arrayjit/lib/.arrayjit.objs/byte/arrayjit__Ndarray.cmo -c -impl arrayjit/lib/ndarray.pp.ml)
# File "arrayjit/lib/ndarray.ml", line 544, characters 32-39:
# 544 |       (if brief then Fn.id else B.frame)
#                                       ^^^^^^^
# Error: This expression has type "?stretch:bool/2 -> B.t -> B.t"
#        but an expression was expected of type "'a -> 'a"
#        File "_none_", line 1:
#          Definition of type "bool/2"

Since you maintain that one, can you confirm whether this is related to the changes here?

@lukstafi
Copy link
Contributor Author

Yes, unfortunately inside PR #27203 I missed a couple dependency upper bounds to address the incompatibility.

@lukstafi
Copy link
Contributor Author

Remaining failures are not related to ppx_minidebug.

  • Target freebsd-ocaml-5.3-amd64 failure ppxlib.0.34.0 failed to build also affects PRs: #27250, #27216, #27204, #27202, #27070, #26297, #26111, #25379 -- so probably all PR packages that depend on ppxlib for freebsd.
  • Targets ocaml-4.14-flambda and ocaml-4.14-flambda-fp failure uunf.16.0.0 failed to build: the long-standing problem with this combination.

@shonfeder
Copy link
Contributor

shonfeder commented Jan 13, 2025

Great, thank you for looking and for fixing the package! Thanks also for the updates!

@shonfeder shonfeder merged commit e5d038c into ocaml:master Jan 13, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants