Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release of OCaml 5.3.0 #27231

Merged
merged 2 commits into from
Jan 8, 2025
Merged

release of OCaml 5.3.0 #27231

merged 2 commits into from
Jan 8, 2025

Conversation

Octachron
Copy link
Member

This PR adds the opam package for the newly release OCaml 5.3.0 compiler:
More precisely, it adds the core compiler package

  • ocaml-compiler.5.3.0

and its two variants

  • ocaml-base-compiler.5.3.0
  • ocaml-variants.5.3.0+trunk

completed by the system version

  • ocaml-system.5.3.0 (where I have removed the non-windows arch package)

Simultaneously, this PR moves the dev package

  • ocaml-variants.5.3.0+trunk to ocaml-variants.5.3.1+trunk

and adds the necessary metapackage

  • ocaml.5.3.1

This time, I have included the two related packages

  • ocaml-src.5.3.0
  • ocaml-manual.5.3

@Octachron
Copy link
Member Author

cc @mseri @shonfeder @raphael-proust

(I am not sure what it the best way to signal new release of the compiler?)

@mseri
Copy link
Member

mseri commented Jan 8, 2025

Seems to include the various changes for host- and arch- packages for windows and to unbreak lock files on other systems that we discussed recently. Ping @dra27 to double check

Copy link
Member

@dra27 dra27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is correct, because opam has been fixed on macOS et al, but we definitely rename ocaml-variants.5.3.0+trunk to ocaml-variants.5.3.1+trunk (rather than leaving an available: false ocaml-variants.5.3.0+trunk), now?

The changes in ocaml-compiler / ocaml-base-compiler / ocaml-variants are as already tested in #27145 - minor tweak to ocaml-system.5.3.0, just to match the proposal in dra27#20 (keeps system compilers consistent with from-source compilers on Windows).

packages/ocaml-system/ocaml-system.5.3.0/opam Outdated Show resolved Hide resolved
@Octachron
Copy link
Member Author

Concerning the +trunk package, I mostly followed the change in #27100 which removed all not-available opam files. It might makes sense to mark the file as unavailable temporarily?

@raphael-proust
Copy link
Contributor

It might makes sense to mark the file as unavailable temporarily?

the only difference it'd make is that the packages would end up in the archive at the next clean-up

the purpose of the archive is to allow people to restore their setup to a previous state (e.g., they had a binary compiling at some point and they want to have access to the packages that existed at that point)

I don't think we need that for packages which have never eneterd the repo at all, so I suggest we don't add those packages with the false availibility

@Octachron
Copy link
Member Author

Is there anything blocking the merge?

@raphael-proust raphael-proust merged commit a78e724 into ocaml:master Jan 8, 2025
1 of 3 checks passed
@raphael-proust
Copy link
Contributor

🐫 ‼️

@Octachron
Copy link
Member Author

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants