Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oasis2opam.0.6.1 - via opam-publish #4510

Closed
wants to merge 1 commit into from

Conversation

Chris00
Copy link
Member

@Chris00 Chris00 commented Jul 21, 2015

Tool to convert OASIS metadata to OPAM package descriptions
Generate OPAM files from _oasis. Most of the metadata supported by
oasis is translated to OPAM. A simple .install file is written to
handle executables (until oasis supports the functionality itself).



Pull-request generated by opam-publish v0.2.1

@camelus
Copy link
Contributor

camelus commented Jul 21, 2015

✅ All lint checks passed bdef4ba
  • These packages passed lint tests: oasis2opam.0.6.1

✅ Installability check (3718 → 3719)
  • new installable packages (1): oasis2opam.0.6.1

@dbuenzli
Copy link
Collaborator

A simple .install file is written to
handle executables (until oasis supports the functionality itself).

What does this do exactly ? It seems to me that oasis already supports the installation of executables.

@Chris00
Copy link
Member Author

Chris00 commented Jul 21, 2015

On Tue, 21 Jul 2015 02:51:19 -0700, Daniel Bünzli wrote:

| A simple .install file is written to
| handle executables (until oasis supports the functionality itself).

What does this do exactly ? It seems to me that oasis already supports the installation of executables.

But not their removal, unless the initial setup.data is present.

@dbuenzli
Copy link
Collaborator

But not their removal, unless the initial setup.data is present.

But you should not use .install files if the package installs the file itself. .install files are to let opam do the install. If you generate this statically it will lead to problems on windows see ocaml/opam#2253

@Chris00
Copy link
Member Author

Chris00 commented Jul 21, 2015

On Tue, 21 Jul 2015 02:58:47 -0700, Daniel Bünzli wrote:

| But not their removal, unless the initial setup.data is present.

But you should not use .install files if the package installs the file itself. .install files are to let opam do the install. If you generate this statically it will lead to problems on windows see ocaml/opam#2253

I agree that these files should be generated by oasis — that's the meaning of “until oasis supports the functionality itself”. If only I got the time...

@dbuenzli
Copy link
Collaborator

I agree that these files should be generated by oasis — that's the meaning of “until oasis supports the functionality itself”. If only I got the time...

They should be generated only if oasis doesn't perform the install itself and please don't do that meanwhile with oasis2opam, it will break any oasis package using oasis2opam on windows for no good reason.

@Chris00 Chris00 closed this Jul 21, 2015
@Chris00
Copy link
Member Author

Chris00 commented Jul 21, 2015

I will release a version that uses oasis generated setup.* to do the install and removal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants