Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repo add/set-url: add --no-action #4933

Draft
wants to merge 16 commits into
base: master
Choose a base branch
from
Draft

Conversation

rjbou
Copy link
Collaborator

@rjbou rjbou commented Nov 25, 2021

to not initialise the repo directly. It will be fetched on next update. See test file

Fixes #4617

@rjbou rjbou added the PR: WIP Not for merge at this stage label Nov 25, 2021
@rjbou rjbou added this to the 2.2.0~alpha milestone Nov 25, 2021
@rjbou rjbou requested a review from dra27 November 25, 2021 15:42
@rjbou
Copy link
Collaborator Author

rjbou commented Dec 1, 2021

TODO: add non initialised information to have a more specific error message

@rjbou rjbou added PR: QUEUED Pending pull request, waiting for other work to be merged or closed and removed PR: WIP Not for merge at this stage PR: NEEDS UPDATE labels Dec 7, 2021
@dra27
Copy link
Member

dra27 commented Dec 14, 2021

Note from an dev meeting (a few weeks ago 🙈): could possibly add a flag internally to the repo state so that we can identify the first opam update since the url was set so that the warning could be better (to differentiate, say, the network being down and not warning about all the URLs) i.e. allow opam to know the difference between "this URL has never worked / never been checked" and "this URL has started failing since last time"

@dra27
Copy link
Member

dra27 commented May 17, 2022

Cross-referencing #4617, which this will close!

* add repos-config file check
* add some comments
* add some global state rw commands
* update generator to handle repos-config and clean root
* fix --set-default that update config (instead of just updating repo config)
* add repos-config rw loading for last update
reftest: opam root add repo file check
let from_2_1_to_2_2_alpha_repo root _conf =
let f = OpamPath.repos_config root in
OpamStd.Option.iter (OpamFile.Repos_config.write f)
(OpamFile.Repos_config.read_opt f)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be iterated over to set all of the initialised fields to true, given that they must have been initialised before? (cf. the v1.3+ upgrade)?

@rjbou rjbou removed this from the 2.2.0~alpha milestone Feb 7, 2023
@rjbou rjbou added the PR: WIP Not for merge at this stage label Feb 7, 2023
@kit-ty-kate kit-ty-kate added this to the 2.3.0~alpha milestone Jul 9, 2024
@rjbou rjbou marked this pull request as draft July 10, 2024 14:17
@kit-ty-kate kit-ty-kate modified the milestones: 2.3.0~alpha, 2.4.0~alpha1 Sep 3, 2024
@rjbou
Copy link
Collaborator Author

rjbou commented Dec 6, 2024

Discussion in dev meeting: This needs an hue rebase, and it leads to question of updating the repos-config file format. We need to cary more information, other PR add fields too.
see #6327

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: QUEUED Pending pull request, waiting for other work to be merged or closed PR: WIP Not for merge at this stage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

opam repo set-url - add --no-action
3 participants