-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
repo add/set-url: add --no-action
#4933
base: master
Are you sure you want to change the base?
Conversation
|
Note from an dev meeting (a few weeks ago 🙈): could possibly add a flag internally to the repo state so that we can identify the first |
Cross-referencing #4617, which this will close! |
* add repos-config file check * add some comments * add some global state rw commands * update generator to handle repos-config and clean root * fix --set-default that update config (instead of just updating repo config) * add repos-config rw loading for last update
reftest: opam root add repo file check
let from_2_1_to_2_2_alpha_repo root _conf = | ||
let f = OpamPath.repos_config root in | ||
OpamStd.Option.iter (OpamFile.Repos_config.write f) | ||
(OpamFile.Repos_config.read_opt f) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be iterated over to set all of the initialised fields to true, given that they must have been initialised before? (cf. the v1.3+ upgrade)?
Discussion in dev meeting: This needs an hue rebase, and it leads to question of updating the repos-config file format. We need to cary more information, other PR add fields too. |
to not initialise the repo directly. It will be fetched on next update. See test file
Fixes #4617