Fix the detection of the current terminal size #6244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kit-ty-kate
force-pushed
the
ioctl_winsz
branch
from
0be59ef
to
b7bbf7b
Compare
rjbou
reviewed
Oct 21, 2024
|
|
||
| let that's_a_no_no _ = failwith "Unix only. This function isn't implemented." | ||
|
|
||
| let get_stdout_ws_col = that's_a_no_no |
kit-ty-kate
force-pushed
the
ioctl_winsz
branch
from
b7bbf7b
to
ce2f0c3
Compare
|
requested change done |
Tested on: * Linux/glibc * Linux/musl * macOS * FreeBSD * OpenBSD * NetBSD * Cygwin
kit-ty-kate
force-pushed
the
ioctl_winsz
branch
from
ce2f0c3
to
ab18706
Compare
|
rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6243
Tested on:
Can't test:
The only change of behaviour between the code previous to #6230 and this one is that prior it would default to 80 column only if you had all 3 (stdout, stdin, stderr) redirected, but now it would default to it if only stdout is redirected, which i think is an improvement.
Backported to 2.3 in #6246