Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove linked switches without failing #6276

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Remove linked switches without failing #6276

wants to merge 3 commits into from

Conversation

btjorge
Copy link

@btjorge btjorge commented Oct 29, 2024 •
edited
Loading

Proposed fix and reproduction test for #6275

@kit-ty-kate kit-ty-kate added this to the 2.4.0~alpha1 milestone Oct 29, 2024
@rjbou rjbou self-requested a review October 29, 2024 16:52
rjbou
rjbou reviewed Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@rjbou rjbou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

I've updated the test (split the commit into before/after), and updated changes too.
I kept a commit as fixup commit to propose an alternative implementation, in order to factorise the check done in remove_dir_t and remove_dir.

@kit-ty-kate kit-ty-kate linked an issue Oct 29, 2024 that may be closed by this pull request
opam switch remove DIR fails on linked switch #6275
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kit-ty-kate kit-ty-kate kit-ty-kate approved these changes

@rjbou rjbou Awaiting requested review from rjbou

Assignees
No one assigned
Labels
KIND: BUG
Projects
None yet
Milestone
2.4.0~alpha1
Development

Successfully merging this pull request may close these issues.

opam switch remove DIR fails on linked switch
3 participants
@btjorge @kit-ty-kate @rjbou