Don't ask confirmation when pinning a new package #6309
Conversation
kit-ty-kate
force-pushed
the
pin-no-ask
branch
from
258058d to
f73569b
Compare
|
Discussion on dev meeting: We agree that the question is too much, but the information remains relevant as it may indicate that a repository is missing or that the package name is mistyped. |
kit-ty-kate
force-pushed
the
pin-no-ask
branch
from
f73569b to
63bdee5
Compare
| (OpamConsole.colorise `bold "NEW")) | ||
| then raise Aborted; | ||
| if not (OpamPackage.has_name st.packages name) then | ||
| OpamConsole.note "Package %s was unknown until now" |
There was a problem hiding this comment.
If anyone has a better idea feel free to change it
There was a problem hiding this comment.
Suggestion
| OpamConsole.note "Package %s was unknown until now" | |
| OpamConsole.note "Package %s does not exist in registered repositories." |
There was a problem hiding this comment.
as a user i would find this message confusing. The repositories we refer to here are opam repositories but they might understand source repositories instead since the command does something with a source repository usually.
There was a problem hiding this comment.
| OpamConsole.note "Package %s was unknown until now" | |
| OpamConsole.note "Package %s does not exist in opam repositories registered in the current switch." |
?
There was a problem hiding this comment.
actually i'm not sure. What do we want to say to users? Maybe something like:
| OpamConsole.note "Package %s was unknown until now" | |
| OpamConsole.note "%s is a new package." |
Fixes #3199
While reading #3199 i asked myself why this question was asked and i couldn't find any reason. It was added in #1335 with no reasoning behind it either.
In my opinion the question is redundant as the user is already asking to pin the package(s).