-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
env: add a flag to output as environment variable bindings #6316
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok with the idea but i'm really not sure about the name of the new option.
--bindings(s)
doesn't really describe anything to me personally. I haven't thought about it much but so far i prefer the original suggestion: --bare
.
One other issue is that the expected usage is to add to the $GITHUB_ENV
file in Github Actions. However the syntax for it is slightly more complex than we can first assume. In the rare case where a newline character is part of the value of an environment variable, the "binding" syntax is not correct anymore.
I think we should check that no newline character exists before printing and fail otherwise.
From dev meeting: Consensus over the name |
Update with |
From (last week) dev meeting: we are going to a full json output for CI, containing the information of the full computed path, and also what to append and/or prepend. Like that CI scripts can use that information to change their environment variables as needed.
|
fix #5791
The name is still to be determined (it's a sed-able name ftm)