fix(database-change): supports the execution of sql by downloading files from a separate bucket #3436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le_download' into ziyan_24v3_feat_sql_plan_task_file_download
kiko-art
requested review from
yhilmare,
guowl3 and
yizhouxw
as code owners
| @@ -29,6 +29,7 @@ | |||
| import org.springframework.jdbc.core.ConnectionCallback; | |||
| import org.springframework.jdbc.core.StatementCallback; | |||
|
|
|||
| import com.amazonaws.util.CollectionUtils; | |||
There was a problem hiding this comment.
Use apache commons instead.
yizhouxw
reviewed
Sep 19, 2024
|
|
||
| if (CollectionUtils.isNullOrEmpty(parameters.getSqlObjectIds())) { | ||
| String sqlContent = parameters.getSqlContent(); | ||
| log.info("SQL content={}", sqlContent); |
There was a problem hiding this comment.
sqlContent may too long for log output
| log.info("SQL content={}", sqlContent); | ||
|
|
||
| List<OffsetString> offsetStringList = processor.split(buffer, sqlContent); | ||
| result.setTotalStatements(offsetStringList.size()); |
There was a problem hiding this comment.
result.setTotalStatements may set out of getSplitSql method, responsibility should isolated
| log.info("successfully read content from cloud storage, objectId={}", objectId); | ||
| String sqlContent = new String(bytes, StandardCharsets.UTF_8); | ||
| List<OffsetString> offsetStringList = processor.split(buffer, sqlContent); | ||
| splitSqlList.addAll(offsetStringList); |
There was a problem hiding this comment.
read all sql statement into memory may cost a lot of memory,
the database change task already contains stream read/split logic, sql plan may follow the same flow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
type-bug
What this PR does / why we need it:
sql plan task supports the execution of sql by downloading files from a separate bucket
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Additional documentation e.g., usage docs, etc.: