Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(external tables): supports syncing external table files #3802

Merged
merged 4 commits into from
Nov 13, 2024

Conversation

zijiacj
Copy link
Collaborator

@zijiacj zijiacj commented Nov 8, 2024

What type of PR is this?

type-feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Additional documentation e.g., usage docs, etc.:


@zijiacj zijiacj added this to the ODC 4.3.3 milestone Nov 8, 2024
@zijiacj zijiacj self-assigned this Nov 8, 2024
@zijiacj zijiacj changed the title feat(external tables):support syncing external table files [wip]feat(external tables):support syncing external table files Nov 8, 2024
@yhilmare yhilmare changed the title [wip]feat(external tables):support syncing external table files [WIP] feat(external tables): supports syncing external table files Nov 8, 2024
@zijiacj zijiacj changed the title [WIP] feat(external tables): supports syncing external table files feat(external tables): supports syncing external table files Nov 11, 2024
@zijiacj zijiacj added the type-feature The functionality to be implemented label Nov 12, 2024
yhilmare
yhilmare previously approved these changes Nov 13, 2024
Copy link
Contributor

@yhilmare yhilmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

PeachThinking
PeachThinking previously approved these changes Nov 13, 2024
Copy link
Collaborator

@PeachThinking PeachThinking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zijiacj zijiacj dismissed stale reviews from PeachThinking and yhilmare via 833c3b0 November 13, 2024 07:24
Copy link
Contributor

@yhilmare yhilmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@MarkPotato777 MarkPotato777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@PeachThinking PeachThinking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yhilmare yhilmare merged commit f8bffce into dev/4.3.x Nov 13, 2024
7 checks passed
@yhilmare yhilmare deleted the feat/zijia_support_sync_external_table_files branch November 13, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-feature The functionality to be implemented
Projects
Status: Developed
Development

Successfully merging this pull request may close these issues.

4 participants