Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #828 - Correct predictoor profit calculation formula #829

Merged
merged 6 commits into from
Apr 24, 2024

Conversation

trizin
Copy link
Contributor

@trizin trizin commented Apr 22, 2024

Fixes #828

Changes proposed in this PR:

  • Correct predictoor profit calculation formula
  • Update tests

About the fix

Current implementation

profit = initial stake + earned

Fix

profit = earned

@trizin trizin linked an issue Apr 22, 2024 that may be closed by this pull request
Copy link

codeclimate bot commented Apr 24, 2024

Code Climate has analyzed commit a40351d and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 93.0%.

View more on Code Climate.

@trizin trizin marked this pull request as ready for review April 24, 2024 12:34
@trizin trizin requested a review from trentmc April 24, 2024 12:34
@trentmc trentmc changed the title #828 - Correct predictoor profit calculation formula Fix #828 - Correct predictoor profit calculation formula Apr 24, 2024
@trizin trizin merged commit f7dd233 into main Apr 24, 2024
6 checks passed
@trizin trizin deleted the issue828-buggy-rose-reward-profit-calculation branch April 24, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug, Pdr bot] Buggy ROSE reward profit calculation
2 participants