Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V4 barge #1608

Closed
wants to merge 7 commits into from
Closed

V4 barge #1608

wants to merge 7 commits into from

Conversation

rogargon
Copy link

This PR tries to address some issues when trying to use the market just over locally deployed infrastructure (aquarius, ganache, contracts, thegraph, provider,...), similar to those described in #1567.

Changes proposed in this PR:

  • Example .env to use with barge
  • Add local barge to networks-metadata.json
  • Use dev config with locally deployed contracts for network 8996
  • start-local script triggering local ocean-subgraph codegen

Altogether, they should make it easier to use the market locally. Tested and able to publish both a dataset and an algorithm. I also bought and downloaded the dataset.

@vercel
Copy link

vercel bot commented Jul 19, 2022

@rogargon is attempting to deploy a commit to the Ocean Protocol Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Jul 28, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
market ❌ Failed (Inspect) Jul 28, 2022 at 1:59PM (UTC)

@mihaisc
Copy link
Contributor

mihaisc commented Jul 28, 2022

All the builds seem to fail.

@kremalicious
Copy link
Contributor

kremalicious commented Jul 28, 2022

this affects too much running the app against remote networks, like always adding dev network to network selection at all times. And unnecessary duplication with added scrips which only change 1 line.

So this would need some more thinking and a better strategy, like:

  • read out the chainIdsSupported & chainIds arrays from .env vars
  • read out subgraph URI for pre-generation from .env vars
  • then pretty sure we need some signal from user that they want to run against barge, as we need to conditionally load or not load contract artifacts, like another env var, or loading a specific .env.barge file. Or use a new npm run start:local command. Ideas welcome
  • once we have this user intention, it's trivial to keep single scripts and have conditions in them rather than duplicating them all
  • local barge network info and a mechanism to get contract addresses via env vars is part of ocean.js, so worth looking into its ConfigHelper

@htcarr3
Copy link

htcarr3 commented Aug 3, 2022

I'm glad to see someone trying to get some traction on this. The docs don't paint an accurate picture on how to make barge/market stack work locally, and has made onboarding our team slow and developing on ocean difficult. There are errors if you don't include an infura project id, errors when trying to connect to local ganache, and various development configs (ocean.ts) are commented out without any mention in the docs. We would be happy to help develop a friendlier local dev environment. Can you help clear up what are the known local development issues?

@shadmoney
Copy link

shadmoney commented Aug 4, 2022

I'm glad to see someone trying to get some traction on this. The docs don't paint an accurate picture on how to make barge/market stack work locally, and has made onboarding our team slow and developing on ocean difficult. There are errors if you don't include an infura project id, errors when trying to connect to local ganache, and various development configs (ocean.ts) are commented out without any mention in the docs. We would be happy to help develop a friendlier local dev environment. Can you help clear up what are the known local development issues?

Agreed on this sentiment, we would also like to contribute back to the documentation on the missing gaps. Solving this lack of good documentation is key in getting adoption and also will help more teams build on ocean quickly and efficiently.

@rogargon
Copy link
Author

rogargon commented Aug 4, 2022

The same for us, not being able to run the Market on a local Barge was complicating our development efforts. These changes are just a quick and dirty successful test as we have been able to make it work. We will continue elaborating on them, so the tests pass and it integrates smoothly into the main branch. Additionally, we can add a section to the README about the steps to get it working

@htcarr3
Copy link

htcarr3 commented Aug 4, 2022

Thank you, yes at the very least the README should make it clear that, while barge can be run locally, market does not work with it out of the box. The docs currently read as if it should work out of the box.

@kremalicious kremalicious marked this pull request as draft September 26, 2022 13:03
@kremalicious
Copy link
Contributor

This will be taken over by #1729 and all solutions to this incorporated there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants