Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump connectkit to 1.3.0 and add support for walletconnect 2.0 #1937

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

bogdanfazakas
Copy link
Member

@bogdanfazakas bogdanfazakas commented Jun 27, 2023

Fixes # .

Changes proposed in this PR:

@vercel
Copy link

vercel bot commented Jun 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dubai-challenge ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 27, 2023 4:35am
market ✅ Ready (Inspect) Visit Preview Jun 27, 2023 4:35am
odc ✅ Ready (Inspect) Visit Preview Jun 27, 2023 4:35am

@codeclimate
Copy link

codeclimate bot commented Jun 27, 2023

Code Climate has analyzed commit 3ad6057 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 20.5% (0.0% change).

View more on Code Climate.

@bogdanfazakas bogdanfazakas marked this pull request as ready for review June 27, 2023 08:43
Copy link
Member

@jamiehewitt15 jamiehewitt15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me

Copy link
Contributor

@EnzoVezzaro EnzoVezzaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The connection seems ok, but I'm having issues to consume fixed rate assets.

Screenshot 2023-06-27 at 09 56 24

Free assets are ok:
Screenshot 2023-06-27 at 09 56 33

Not sure it's related to this PR, probably not. But can you just take at look very quick, if it's not related then we can approved this PR and open an issue for this.

UPDATES:

on prod market fixed rate assets are working

Screenshot 2023-06-27 at 10 00 16

it's weird because even the amount seems off by a little:

This is the same asset on this PR:

Screenshot 2023-06-27 at 10 11 33

@bogdanfazakas
Copy link
Member Author

The connection seems ok, but I'm having issues to consume fixed rate assets.

Not sure it's related to this PR, probably not. But can you just take at look very quick, if it's not related then we can approved this PR and open an issue for this.

UPDATES:

on prod market fixed rate assets are working
it's weird because even the amount seems off by a little:

This is the same asset on this PR:

I'm able to consume, maybe there are some known issues with approvals or network switch 🤔
Screenshot 2023-06-27 at 17 28 44

@bogdanfazakas bogdanfazakas merged commit 11808fb into main Jun 27, 2023
@bogdanfazakas bogdanfazakas deleted the use-connectkit-1.3.0 branch June 27, 2023 14:40
@bogdanfazakas
Copy link
Member Author

merged the PR since the wallet connection was not working for me anymore on the main market.oceanprotol.com website

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants