-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump connectkit to 1.3.0 and add support for walletconnect 2.0 #1937
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Code Climate has analyzed commit 3ad6057 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 20.5% (0.0% change). View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The connection seems ok, but I'm having issues to consume fixed rate assets.
Not sure it's related to this PR, probably not. But can you just take at look very quick, if it's not related then we can approved this PR and open an issue for this.
UPDATES:
on prod market fixed rate assets are working
it's weird because even the amount seems off by a little:
This is the same asset on this PR:
I'm able to consume, maybe there are some known issues with approvals or network switch 🤔 |
merged the PR since the wallet connection was not working for me anymore on the main market.oceanprotol.com website |
Fixes # .
Changes proposed in this PR: