-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/Fallback to subgraph price #1959
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
@bogdanfazakas are you working on the comment I left? The rest seems fine 👍🏽 once we're done with what I commented, I can approve this 👍🏽 |
Hi @EnzoVezzaro we covered this last week, we have the isseu with no pricing avaialable in the homepage because we are not using subgraph there and decided to keep using subgraph fallback only on asset detail page. |
great 👍🏽 then after resolving the conflicts I can approve this 👏🏽 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I have one left comment on this PR, once answered we can ship this PR.
@bogdanfazakas Are we ready to merge this one? |
Code Climate has analyzed commit f38f580 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 0.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 20.1% (0.0% change). View more on Code Climate. |
Fixes #1956 .
Changes proposed in this PR: