Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/Fallback to subgraph price #1959

Merged
merged 10 commits into from
Oct 18, 2023
Merged

Conversation

bogdanfazakas
Copy link
Member

@bogdanfazakas bogdanfazakas commented Aug 29, 2023

Fixes #1956 .

Changes proposed in this PR:

  • check if price is stored in aqua and use subgraph price value if not available as fallback

@vercel
Copy link

vercel bot commented Aug 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
market ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2023 9:09pm
odc ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2023 9:09pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
dubai-challenge ⬜️ Ignored (Inspect) Visit Preview Oct 16, 2023 9:09pm

@bogdanfazakas bogdanfazakas marked this pull request as draft August 29, 2023 13:26
@EnzoVezzaro
Copy link
Contributor

free teasers seems fine, but fixed price says: "No pricing schema available"

Screenshot 2023-09-01 at 09 59 49

if you click the asset, you can actually see the price.

@EnzoVezzaro
Copy link
Contributor

@bogdanfazakas are you working on the comment I left? The rest seems fine 👍🏽 once we're done with what I commented, I can approve this 👍🏽

@bogdanfazakas
Copy link
Member Author

@bogdanfazakas are you working on the comment I left? The rest seems fine 👍🏽 once we're done with what I commented, I can approve this 👍🏽

Hi @EnzoVezzaro we covered this last week, we have the isseu with no pricing avaialable in the homepage because we are not using subgraph there and decided to keep using subgraph fallback only on asset detail page.

@EnzoVezzaro
Copy link
Contributor

@bogdanfazakas are you working on the comment I left? The rest seems fine 👍🏽 once we're done with what I commented, I can approve this 👍🏽

Hi @EnzoVezzaro we covered this last week, we have the isseu with no pricing avaialable in the homepage because we are not using subgraph there and decided to keep using subgraph fallback only on asset detail page.

great 👍🏽 then after resolving the conflicts I can approve this 👏🏽

Copy link
Contributor

@EnzoVezzaro EnzoVezzaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I have one left comment on this PR, once answered we can ship this PR.

src/components/Asset/AssetActions/Compute/index.tsx Outdated Show resolved Hide resolved
@LoznianuAnamaria
Copy link
Contributor

@bogdanfazakas Are we ready to merge this one?

@codeclimate
Copy link

codeclimate bot commented Oct 16, 2023

Code Climate has analyzed commit f38f580 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 0.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 20.1% (0.0% change).

View more on Code Climate.

@bogdanfazakas bogdanfazakas merged commit ba17184 into main Oct 18, 2023
15 checks passed
@bogdanfazakas bogdanfazakas deleted the fix/fallback-to-subgraph-price branch October 18, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing fallback to subgraph if metadata cache price is not available
3 participants