Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor code to remove refs to dbs #84

Merged
merged 7 commits into from
Oct 6, 2023

Conversation

EnzoVezzaro
Copy link
Contributor

@EnzoVezzaro EnzoVezzaro commented Oct 5, 2023

refactor code to remove refs to dbs

  • update readme
  • small fixes

WAITING: we need to make some changes on vercel before merging this PR as it will break the release

WARNING: this PR will break the vercel's previews for some env vars. In local doesn't have this problem.

refactor code to remove refs to dbs
+ update readme
+ small fixes
@EnzoVezzaro EnzoVezzaro self-assigned this Oct 5, 2023
@vercel
Copy link

vercel bot commented Oct 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dbs-ui-lib ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 6, 2023 8:05am

@EnzoVezzaro EnzoVezzaro marked this pull request as ready for review October 6, 2023 07:18
Copy link
Member

@jamiehewitt15 jamiehewitt15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a .example.env file?

Copy link
Member

@jamiehewitt15 jamiehewitt15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it works well.

@EnzoVezzaro EnzoVezzaro merged commit e404fdd into main Oct 6, 2023
8 checks passed
@EnzoVezzaro EnzoVezzaro deleted the fix/issue-83-refactor-dbs-uploader branch October 6, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor "dbs" to "Uploader"
2 participants