Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added try catch on complete upload #95

Merged
merged 4 commits into from
Oct 24, 2023

Conversation

EnzoVezzaro
Copy link
Contributor

Changes proposed in this PR:

  • avoid loading spinner when upload fails

@vercel
Copy link

vercel bot commented Oct 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dbs-ui-lib ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2023 0:15am

// Check if user has wrapped matic in their wallet
if (wmaticBalance < newQuoteFee) {
console.log('User does not have enough wMatic')
setErrorUpload(true)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having no WMATIC isn't an upload error, it's part of the normal user flow now. We shouldn't show an error message for this. If we show any message it should be an info message

@EnzoVezzaro EnzoVezzaro merged commit 2c81f54 into main Oct 24, 2023
9 checks passed
@EnzoVezzaro EnzoVezzaro deleted the fix/issue-94-loading-state-upload branch October 24, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

if the component fails when uploading the file, the spinners keeps loading
2 participants