Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Krb5 utils stuff #211

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Krb5 utils stuff #211

wants to merge 4 commits into from

Conversation

axmmisaka
Copy link

more descriptions later, it's 4:35am and im killing myself

@axmmisaka axmmisaka mentioned this pull request May 13, 2020
Closed
cg505
cg505 reviewed May 13, 2020
View reviewed changes
Copy link
Member

@cg505 cg505 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm.... two things to note: you might want to make it work with non-admin principals too (like user/root or just plain user). also, we should only do the sudo if the script is running as root. but we might want to do this while normally running as the user.

@cg505
Copy link
Member

cg505 commented May 13, 2020

test failure is just the linter, should be nbd to fix

@axmmisaka
Copy link
Author

will fix soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cg505 cg505 cg505 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@axmmisaka @cg505