hiding regular hours by default #355
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriskuehl
reviewed
Nov 28, 2017
| <h3>Regular Weekly Hours</h3> | ||
| <h3>Regular Weekly Hours</h3> | ||
| <button class = "btn btn-primary" id = "weekly_hours_btn" onclick="toggle_weekly_hours()" style="opacity:0.3;">Show</button> | ||
| <div id = "weekly_hours" style="display:none;"> |
There was a problem hiding this comment.
weird spacing around some of the = signs
| $("#weekly_hours").hide(); | ||
| } | ||
| } | ||
| </script> |
There was a problem hiding this comment.
Can we use something from Bootstrap instead of reinventing it ourselves?
https://getbootstrap.com/docs/3.3/javascript/#collapse-example looks like basically what you want. Plus we get nice transitions this way.
There was a problem hiding this comment.
(to clarify, we already have all the bootstrap css/js, so it should be as simple as adding the right classes and hooking things up; the example there should help)
|
@karenytu just a friendly reminder about this |
|
@karenytu bump |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed ocf.berkeley.edu/docs/services/lab/ and made the regular weekly hours hidden by default. The reasoning for this change is because Sahil said that people would ignore the actual hours above the regular weekly hours and get confused about lab opening times...
Screenshots of the page on load and after button click are attached.
