Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

low key oom should restart desktops #1422

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

low key oom should restart desktops #1422

wants to merge 1 commit into from

Conversation

lharriscal
Copy link
Contributor

Desktops just hang on a frozen screen if they run out of memory. Chrome likes using a lot of memory. I would argue that restarting the computer automatically is a more desirable behaviour for the end user than just freezing.

Therefore, on out of memory we now kernel panic, and on kernel panics we restart the computer after 5 seconds.

Already tested on firewhirl

etw wanted to test something else though before merging this.

@kpengboy
Copy link
Member

Question: in OOM situations why doesn't the OOM killer kill the most offending process, thus solving the problem without a reboot? Can it be tuned to kill before the system freezes? What unintended side effects might there be if we kernel panic instantly on OOM?

@lharriscal
Copy link
Contributor Author

Question: in OOM situations why doesn't the OOM killer kill the most offending process, thus solving the problem without a reboot? Can it be tuned to kill before the system freezes? What unintended side effects might there be if we kernel panic instantly on OOM?

You are definitely right on this so I did some investigation. I tried to replicate computer freezing on OOM, and I was able to do so. I tried on another computer and OOM killer functioned as expected. I am not sure whether it just only sometimes functions as expected or if it only works on some computers. more testing required.

However, none of these cases are hit in practice except on computers with low memory. Once we upgrade the problematic desktop, we likely wont run into this issue often.

@lharriscal
Copy link
Contributor Author

Ok so I did a bit more research. Looks like it is just a few specific desktops that have this issue.

@cg505
Copy link
Member

cg505 commented Feb 15, 2024

banger PR title
is it related to differences in swap?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants