Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makeservices: add makexmpp script #112

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

makeservices: add makexmpp script #112

wants to merge 1 commit into from

Conversation

dkess
Copy link
Member

@dkess dkess commented Jun 7, 2019

This lets users create their own XMPP accounts. The script might seem daunting but it's actually not as complicated as it seems. It connects as the XMPP admin and attempts to change the user's password. If that errors, it then tries to create the account. This relies on sudo rules in ocf/puppet#659.

Copy link
Member

@kpengboy kpengboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this. I have left comments.

For a bonus, we could perhaps colorize some of the text.

makeservices/makexmpp-real Outdated Show resolved Hide resolved

condition = iq['error']['condition']
errtext = iq['error']['text']
raise Exception('{}: {}'.format(condition, errtext))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use a more specific subclass of Exception?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is a huge deal, since this is only seen by the emailed problem report in the root@ mailing list. We'll see the line number which is more important anyways.

makeservices/makexmpp-real Outdated Show resolved Hide resolved
makeservices/makexmpp-real Outdated Show resolved Hide resolved
makeservices/makexmpp-real Show resolved Hide resolved
@dkess
Copy link
Member Author

dkess commented Jun 12, 2019

Thanks for the feedback, I've made most of the suggested changes. Not opposed to colorized output but I'd rather do it in a separate commit, and it's not a huge priority IMO.

makeservices/makexmpp-real Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants