-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
makeservices: add makexmpp script #112
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this. I have left comments.
For a bonus, we could perhaps colorize some of the text.
|
||
condition = iq['error']['condition'] | ||
errtext = iq['error']['text'] | ||
raise Exception('{}: {}'.format(condition, errtext)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use a more specific subclass of Exception
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is a huge deal, since this is only seen by the emailed problem report in the root@
mailing list. We'll see the line number which is more important anyways.
Thanks for the feedback, I've made most of the suggested changes. Not opposed to colorized output but I'd rather do it in a separate commit, and it's not a huge priority IMO. |
Co-authored-by: Kevin Peng <[email protected]>
This lets users create their own XMPP accounts. The script might seem daunting but it's actually not as complicated as it seems. It connects as the XMPP admin and attempts to change the user's password. If that errors, it then tries to create the account. This relies on sudo rules in ocf/puppet#659.