chore(get): improve error reporting on HTTP errors

ocpi · Feb 4, 2023 · 5c60ad5 · 5c60ad5
1 parent 5c06eed
commit 5c60ad5
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 15 deletions.
diff --git a/src/commands/get.ts b/src/commands/get.ts
@@ -74,10 +74,16 @@ export const get = async (moduleName: string, privacyPass?: string) => {
     },
   });
 
-  pipeline(
-    ocpiObjectStream,
-    privacyFilteringStream,
-    jsonEncodingStream,
-    stdout
-  );
+  try {
+    await pipeline(
+      ocpiObjectStream.on("error", () => console.debug("aargh!")),
+      privacyFilteringStream,
+      jsonEncodingStream,
+      stdout
+    );
+  } catch (err) {
+    console.log(
+      `Error fetching data from OCPI platform: ${(err as Error)?.message}`
+    );
+  }
 };
diff --git a/src/ocpi-request.ts b/src/ocpi-request.ts
@@ -262,16 +262,22 @@ export function fetchDataForModule<N extends ModuleID>(
         return;
       }
 
-      const firstPageParameters = { offset: 0, limit: size };
-      const nextPageData = await pullPageOfData(
-        session,
-        module,
-        nextPage === "notstarted" ? firstPageParameters : nextPage
-      );
-      if (nextPageData === "no such endpoint") {
-        throw new Error(`no endpoint found for module ${module.name}`);
+      let nextPageData;
+      try {
+        const firstPageParameters = { offset: 0, limit: size };
+        nextPageData = await pullPageOfData(
+          session,
+          module,
+          nextPage === "notstarted" ? firstPageParameters : nextPage
+        );
+        if (nextPageData === "no such endpoint") {
+          throw new Error(`no endpoint found for module ${module.name}`);
+        }
+        console.debug("Page fetched", nextPageData);
+      } catch (err) {
+        this.emit("error", err);
+        return;
       }
-      console.debug("Page fetched", nextPageData);
 
       nextPage = nextPageData.nextPage ?? "done";