Deprecate URLBuilder in favor of AddressBuilder. #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are the last two internal use cases for URLBuilder. And replacing them makes my IDE happy. Both are similar to the create case but different. InboundRewriteRuleAdaptor needs the encoding. RewriteViewHandler needs to merge two query strings.
|
Thanks! But it looks like you broke the CI build... |
mdfst13
force-pushed
the
url-builder-deprecation
branch
from
2c489d8
to
f816724
Compare
added 7 commits
September 13, 2018 14:59
If we send an invalid URL to the URI parser, it falls over and fails. But apparently we are supposed to accept and fix rules that produce invalid URLs. So encode URL before we try to parse it.
String.join did not exist prior to Java 8. So implement manually with StringBuilder.
Use Pattern.quote to escape the question mark and use it literally.
Since both pathEncoded and pathDecoded decode the string, use pathDecoded so people will know what's happening.
As this test is not failing locally and not producing useful information on Travis, adding a message to the failing assertion.
We cast event to HttpServletRewrite before getting the inbound address. We do not need to keep doing it, as we have the cast version stored.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the last two internal use cases for URLBuilder. And replacing them makes my IDE happy without having to suppress warnings. Both are similar to the create case but different.
InboundRewriteRuleAdaptor needs encoding.
RewriteViewHandler needs to merge two query strings.