-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(mappings): Add Prowler example #78
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Specific comments are inline.
A few notes:
- Can you run the transformed output through OCSF validator? I am seeing a few issues that the validator could have caught. Validator is available in the ocsf-server.
- In the samples dir, can you also add a
prowler.raw
file with the corresponding raw input record?
First of all, I apologise if I'm doing something wrong I'm checking it by calling https://schema.ocsf.io/api/validate with a POST request but I always receive the same error message even having that value in the mapping, as per https://github.com/ocsf/examples/pull/78/files#diff-b322e9b9688ddcf1d96e52975883fa04e35d8fb92468424beedb643e5d663454R114
I tried with several mappings from this repo:
... and I always receive the same error, what am I doing wrong? The same happens using the Detection Finding sample from https://schema.ocsf.io/sample/1.3.0/classes/detection_finding P.S.: I've also tried with the
I thought of adding it here but that |
Signed-off-by: Pepe Fagoaga <[email protected]>
Regarding your validation issue, you need to pass a content-type header in your curl. Try appending the following One thing that I can see missing is, metadata.profiles[], you would need to populate this array with all the profiles that are used in the event. You'll see validation errors due to this. For e.g. you would Regarding, this being a natively produced event. Agree, it makes sense to not add a raw sample. |
Signed-off-by: Pepe Fagoaga <[email protected]>
Signed-off-by: Pepe Fagoaga <[email protected]>
Totally my bad, I didn't see that I was using the
Thank you very much for this, now I'm validating all the errors, the only thing I'm not being able to validate is all the timestamps even with the
|
The datetime profile adds new, shadow fields to the schema. These are any timestamp field suffixed with |
Signed-off-by: Pepe Fagoaga <[email protected]>
Thank you for the insight, just added! We have some warnings that we need to review but at least 0 errors using the validation API. |
Signed-off-by: Pepe Fagoaga <[email protected]>
@floydtree everything was addressed, thank you for your review! |
Context
Fix #75
Description
Add Prowler OCSF Detection Finding v1.3.0 example to the mappings folder.