Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runtime: use monomorphic representation for MlBytes #1229

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hhugo
Copy link
Member

@hhugo hhugo commented Jan 18, 2022

Using deoptigate to check performances/optimizations

probably blocked by #1045

@hhugo hhugo marked this pull request as draft January 13, 2023 13:55
@hhugo hhugo changed the title WIP: Runtime: use monomorphic representation for MlBytes Runtime: use monomorphic representation for MlBytes Oct 11, 2024
@hhugo hhugo marked this pull request as ready for review October 11, 2024 08:15
@hhugo
Copy link
Member Author

hhugo commented Oct 14, 2024

If we make Bytes.unsafe_of_string O(n), we would need to fix String.sub, String.get_intN_*, String.get_uintN_*, String.get_utf_*, String.is_valid_utf_*. They convert the whole string argument to bytes but only look at a small subset.

@hhugo hhugo added the blocked label Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant