-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small changes in the internal APIs for Wasm #1654
Conversation
@OlivierNicole, I wonder if we could move faster by not grouping unrelated commits too much. |
Sure, I was worried of the opposite effect of bombarding the repo with too many PRs, hence the grouping. Let me know what you think should be separate PRs. |
I think you should at least move out the sourcemap api commit and the build info in sexp one |
2d5bc4a
to
2f22ec5
Compare
Done. In fact I think I won’t do a PR for the Source_map changes for now, hopefully I can make progress on #1617 soon enough that it won’t be needed for long. |
2f22ec5
to
df2ef7e
Compare
The CI is not happy. @vouillon mentioned elsewhere that it could be due to a missing |
361c0fa
to
460cdf4
Compare
460cdf4
to
2efeb46
Compare
I still get this error:
in spite of the |
You need to initialize the thing in compiler/bin-js_of_ocaml/link.ml inside I think I'd be more confortable moving the explicit initialization to its own PR so that we can discuss alternative and correctness without holding on the rest of this PR. |
2efeb46
to
99e82e0
Compare
Done. I have opened #1662 for explicit initialization. |
99e82e0
to
a9c69e3
Compare
Thanks! |
This PR consists in a number of changes in the APIs of
compiler/lib/
that @vouillon needed while developing wasm_of_ocaml.This is part of a series of PRs intending to reduce the diff between js_of_ocaml and wasm_of_ocaml (see ocaml-wasm/wasm_of_ocaml#47).
It is best reviewed commit by commit.